-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
golangci-lint failing against master branch #320
Comments
Hi ! I took a look at the errors raised by golangci-lint. Most of the errors is due to not checking error values returned by functions. For the moment, I explicitely ignored most of the errors returned, in order to not change the current behavior. However, I think that some errors should be managed. I put a "TODO" comment on these errors in my PR. Feel free to review and give feedback :-) |
Resolved thanks to @boreyuk! Viva la community |
golangci-lint is failing against the
master
branch#310 will fix the build such that golangci-lint can run successfully.
This has highlighted linting errors in the
master
branch which now need resolving :)This issue is to track. Contributions are welcome (Go isn't my strongest language!)
The text was updated successfully, but these errors were encountered: