Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No color output #341

Merged
merged 1 commit into from
Oct 17, 2023
Merged

No color output #341

merged 1 commit into from
Oct 17, 2023

Conversation

stan-is-hate
Copy link
Contributor

@stan-is-hate stan-is-hate commented Sep 18, 2023 •
edited
Loading

Addresses #340

@stan-is-hate stan-is-hate mentioned this pull request Sep 18, 2023
Closed
@coveralls
Copy link

Coverage Status

coverage: 37.187% (-0.01%) from 37.197% when pulling c390b6d on stan-confluent:no-color-output into b93338e on pact-foundation:master.

@stan-is-hate stan-is-hate marked this pull request as ready for review September 19, 2023 16:02
@YOU54F YOU54F requested a review from mefellows September 19, 2023 17:42
@mefellows
Copy link
Member

Thanks for this! I'd prefer that this is an option on the Log interface, however the FFI doesn't put it there. So this makes sense.

Could you please:

  1. Squash your commits
  2. Update the commit message to something that aligns to the commit standard (see https://github.com/pact-foundation/pact-go/blob/master/CONTRIBUTING.md).
  3. Force push

I'd suggest feat: allow disabling of coloured log output in Verifier

The reason is that the commit messages form the basis of our changelog and release notes.

@stan-is-hate
Copy link
Contributor Author

Thanks Matt!
After running the tests locally, some pact .json files are changed. Do you want me to also merge those?

@stan-is-hate
Copy link
Contributor Author

Squashed the commits

@YOU54F
Copy link
Member

YOU54F commented Sep 29, 2023

failures aren't related to this change, its because one of the deps in master doesn't support go vers less than 1.19

I'll get it sorted and do a separate commit to update the pact files 👍🏾

@stan-is-hate
Copy link
Contributor Author

@mefellows @YOU54F friendly ping on this PR :)

@mefellows mefellows merged commit 781c59a into pact-foundation:master Oct 17, 2023
5 of 9 checks passed
@mefellows
Copy link
Member

Thanks, sorry I didn't see the updated commits etc. - merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mefellows mefellows Awaiting requested review from mefellows

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stan-is-hate @coveralls @mefellows @YOU54F