Ci/test x plat #351
Ci/test x plat #351
Conversation
io/ioutil deprecated and replaced with io or os https://pkg.go.dev/io/ioutil\#TempDir deprecation, now uses os.MkTmpDir add ci testing for macOS and windows
Makefile - support exe ext for plugin cli on win macOS - set install_name_tool to full path
requires java 17, try with actions
add x-arch tests
|
ps. failing tests in cirrus ci (and cirrus cli locally) but everything passing on my local mac and also passing on GHA so 🤷🏾♂️ |
|
|
||
| linux_arm64_task: | ||
| env: | ||
| SKIP_PLUGIN_AVRO: "true" |
There was a problem hiding this comment.
I'm assuming this (and related references) was put in the "do it later" basket?
There was a problem hiding this comment.
yeah avro was failing, needs java plus other yaks.
| @@ -57,3 +57,25 @@ jobs: | |||
| with: | |||
| github-token: ${{ secrets.GITHUB_TOKEN }} | |||
| parallel-finished: true | |||
|
|
|||
| test-other-os: | |||
There was a problem hiding this comment.
Is there a reason why you didn't just merge this into the test job above?
This doesn't run the examples, but just the tests from what I can see (which is probably fine, if we ever build the compatibility suite for proper feature regression testing).
There was a problem hiding this comment.
Thought
- try and get build and unit tests working first x plat
- then move onto examples
- consider examples as 2nd class compared to main code that is currently untested in CI x-plat
not sure how yaks we would need to end up shaving to get this working, so thought I would just create a seperate job to check whats needed for these non linux os's, and then could roll everything back together intro one job
There was a problem hiding this comment.
Cool, I thought so. It's better than where we were, but just wanted to clarify.
|
round 2 in #416 |
This PR address lint errors introduced by #347
Also looks to test the Pact Go V2 project on windows and macos in GHA, and on arm64 hardware for linux/macos.
This also recreates the issue noted in #345 and goes some way towards #297
I need to pull out the changes from 9738a2b but just thought I would stick this as a draft, in case people are wondering the golang-lintci is failing