Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pact CLI Install Path #357

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

r-best
Copy link

@r-best r-best commented Oct 19, 2023

Adding ability to specify path to Pact CLI for systems where the CLI can't easily be installed

@mefellows
Copy link
Member

👋 hi there, I see this is still in DRAFT - would you still like to see this added?

@r-best
Copy link
Author

r-best commented Apr 26, 2024

I would! I'll switch the branch so it's for v1.x.x, the functionality was done last time I worked on this but I need to review your contribution guidelines and make sure I'm good on unit testing and everything else
And suggestions where to start for that?

@r-best r-best changed the base branch from master to v1.x.x April 28, 2024 16:54
@r-best r-best changed the title DRAFT: Pact CLI Install Path Pact CLI Install Path Apr 28, 2024
@r-best r-best marked this pull request as ready for review May 1, 2024 14:54
@r-best
Copy link
Author

r-best commented May 7, 2024

@mefellows this is ready for review, let me know if any changes are needed

@coveralls
Copy link

coveralls commented May 8, 2024

Coverage Status

coverage: 77.731% (+0.4%) from 77.323%
when pulling c4eb4a4 on r-best:feat/cli-path
into 0d81b71 on pact-foundation:v1.x.x.

@r-best
Copy link
Author

r-best commented May 31, 2024

@mefellows any update on this?

@mefellows
Copy link
Member

Apologies, I have one last request - could you please squash and reformat your commit to follow the semantic commit conventions in the developer guide?

Something like

feat: add ability to specify standalone CLI path

@r-best
Copy link
Author

r-best commented Jun 4, 2024

Apologies, I have one last request - could you please squash and reformat your commit to follow the semantic commit conventions in the developer guide?

Something like

feat: add ability to specify standalone CLI path

Done! Let me know if anything else is needed 👍

@mefellows mefellows merged commit 9c80346 into pact-foundation:v1.x.x Jun 6, 2024
6 checks passed
@mefellows
Copy link
Member

Thanks - released v1.9.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants