Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: macos runners #439

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

YOU54F
Copy link
Member

@YOU54F YOU54F commented Jul 3, 2024

No description provided.

@coveralls
Copy link

Coverage Status

coverage: 29.23% (+0.1%) from 29.134%
when pulling 520049d on YOU54F:ci/macos_runners
into c80e188 on pact-foundation:master.

@mefellows
Copy link
Member

Woo!

Screenshot 2024-07-04 at 2 12 26 PM

@mefellows
Copy link
Member

mefellows commented Jul 4, 2024

This change relies on #437, so will hold off until we find as solution for that.

UPDATE: converted to Draft so I don't accidentally merge it as CI is passing :)

@mefellows mefellows marked this pull request as draft July 4, 2024 07:12
@YOU54F YOU54F force-pushed the ci/macos_runners branch from 520049d to 8631f64 Compare July 4, 2024 10:57
@YOU54F YOU54F force-pushed the ci/macos_runners branch from 8631f64 to 2cb2b62 Compare July 4, 2024 11:00
@YOU54F YOU54F marked this pull request as ready for review July 4, 2024 11:02
@YOU54F
Copy link
Member Author

YOU54F commented Jul 4, 2024

Pulled out change for #437 which is no longer required, so the changes in the PR are trivial.

Note: still seeing segfaults on provider side occasionally, which will be related to the timing of the installed signal handlers, haven't seen any on the consumer side, where we have the ability to install the signal handlers after the plugin has been started

@YOU54F YOU54F merged commit fd44da5 into pact-foundation:master Jul 4, 2024
14 checks passed
@coveralls
Copy link

Coverage Status

coverage: 29.358% (+0.1%) from 29.248%
when pulling 2cb2b62 on YOU54F:ci/macos_runners
into f3b61a7 on pact-foundation:master.

@YOU54F YOU54F deleted the ci/macos_runners branch July 4, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants