fix: update pact ffi headers to 0.4.21 and map types #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a pact.h file which was in the source, but wasn't included, so we were inlining types.
This update the pact_ffi.h file to match with our current lib 0.4.21 and matches the types so we can directly map from the pact.h file.
We did need to update the enum types for INTERACTION_PART and LEVEL_FILTER to int's for ease of use but there are no external user facing changes in behaviour so I think this is potentially a better solution and avoids potential mismatches as seen in #89