Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add cgo pre-reqs and tips for macos/windows #442

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

YOU54F
Copy link
Member

@YOU54F YOU54F commented Jul 4, 2024

@coveralls
Copy link

Coverage Status

coverage: 29.358%. remained the same
when pulling 7625481 on docs/cgo_requirement
into fd44da5 on master.

@coveralls
Copy link

Coverage Status

coverage: 29.358%. remained the same
when pulling 15e796f on docs/cgo_requirement
into fd44da5 on master.

@YOU54F YOU54F mentioned this pull request Jul 4, 2024
README.md Show resolved Hide resolved
@mefellows mefellows merged commit a396cac into master Jul 4, 2024
30 checks passed
@mefellows mefellows deleted the docs/cgo_requirement branch July 4, 2024 23:31
@mefellows
Copy link
Member

I wonder if we should have the install command perform the OS-specific install instructions. Perhaps it could add the environment variables automatically?

@YOU54F
Copy link
Member Author

YOU54F commented Jul 5, 2024

That sounds like a really good plan tbh.

I've thought many times about storing the shared lib in $HOME/.pact/ffi or specifically at versioned subfolders, as it would make testing a bit easier when working cross-lang.

Setting some flags, and possibly having a pact-go doctor that can check the systems pre-reqs and let the user know what they need to install.

we would want to preserve any of the users existing CGO_* vars that we set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants