Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(broker): use 'pb:pacts' instead 'pacts' (broker v2.19.0) #82

Conversation

gaelollivier
Copy link
Contributor

This fixes a bug introduced in pact broker v2.19.0 (pact-foundation/pact_broker#209) which results in only the latest consumer being verified when running provider verification tests.

@mefellows
Copy link
Member

Thanks @gaelduplessix, if you could get those tests to pass i'll bring this straight in.

@gaelollivier
Copy link
Contributor Author

gaelollivier commented May 18, 2018

  • Fixed the broker tests, now I get installer_test.go:42: error: exec: "pact-mock-service": executable file not found in %PATH%, not sure how to fix this 🤔
  • I realised that this PR will actually make the go-client require pact-broker >v2.19.0, is that ok ? Should probably be written in the released notes

@gaelollivier
Copy link
Contributor Author

While I was at it, I cherry-picked 2e0fc84 on my PR because my tests were failing now that they're properly loading multiple pacts ^^'

@mefellows
Copy link
Member

@gaelduplessix apologies, feat/daemonless is a defunct branch. I'll move all of the active code into release/1.x.x which will be the next major version. These changes are already in it.

@mefellows mefellows closed this May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants