feat: expose faiIfNoPactsFound on the VerifierOptions #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwitko
force-pushed
the
add-no-fail-if-no-pacts
branch
2 times, most recently
from
308f092
to
135691f
Compare
|
adamwitko
force-pushed
the
add-no-fail-if-no-pacts
branch
from
135691f
to
72eeb08
Compare
|
Thanks @adamwitko. I've been off for a long weekend, will review this week - appreciate the PR. Most of this work is just mapping arguments to the underlying process, where the real logic/behaviour exists. I'm less concerned about an integration test for this behaviour at this layer, but we could look to sure up the unit test coverage. A lot of the mapping is enforced at the type (TS) level, but of course this doesn't guarantee behaviour/validation in JS land. |
mefellows
reviewed
Oct 18, 2022
|
Closing this one and have pushed a small change to address comments - thanks Adam, if the build passes I'll merge and release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add in the ability for Providers to specify if they want to pass or fail when no pacts can be found to verify.
Fixes (pact-foundation/pact-js#941)