Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PactJs not support Jest@21.2.1 #132

Closed
dongxiaonan opened this issue Dec 7, 2017 · 2 comments
Closed

PactJs not support Jest@21.2.1 #132

dongxiaonan opened this issue Dec 7, 2017 · 2 comments

Comments

@dongxiaonan
Copy link

Software versions

  • **Windows 8
  • Consumer Pact library: Pact JS v4.2.1
  • Node Version: node v8.2.1
  • Testing framework and version: Jest@21.2.1

Actual behaviour

image

Steps to reproduce

Setup the example given by pactJs - Jest.
Install the jest with latest package.
run the test, it will fail.

When try to install Jest@20.0.0
run the test, could get correct result
@mefellows
Copy link
Member

This sounds like more a problem with Jest than with Pact. What's changed between those two versions?

mefellows added a commit that referenced this issue Dec 8, 2017
@mefellows
fix(jest): update jest example to be compatible with v21.x.x (#132)
7fabfc4
@mefellows
Copy link
Member

OK just took a quick look. Looks like the way Jests resolve promises in tests now fail if there is content returned to the successful promise. Modified the tests and bumped version to v21.x.x. Check examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mefellows @dongxiaonan