Updated API for 2.0.0 release #23
Conversation
| @@ -8,8 +8,8 @@ check: | |||
| functions: 80 | |||
| excludes: [] | |||
| each: | |||
| statements: 80 | |||
| lines: 80 | |||
| statements: 60 | |||
There was a problem hiding this comment.
I needed to do this because the Verifier class is basically a wrapper of pact-node's Verifier and the integration tests didn't seem to cover it. Any unit test would stub it out such that it would be a useless test.
| @@ -6,7 +6,7 @@ var DIST = path.resolve(__dirname, '../dist'); | |||
| var APP = path.resolve(__dirname, '../src'); | |||
|
|
|||
| module.exports = { | |||
| entry: path.resolve(APP, 'pact.js'), | |||
| entry: path.resolve(APP, 'pact-karma.js'), | |||
There was a problem hiding this comment.
Similarly, as pact-node became a dependency, webpack pooped its pants and obviously couldn't deal with a few thousand Ruby files now on the path (and of course, this would never work in the browser). It seemed this was the cleanest option, albeit with some duplication.
| @@ -14,6 +14,7 @@ | |||
| "license": "MIT", | |||
| "devDependencies": { | |||
| "@pact-foundation/pact-node": "^4.6.0", | |||
| "cli-color": "^1.1.0", | |||
There was a problem hiding this comment.
This is to make the console nice and red when there is a Pact failure (see https://github.com/pact-foundation/pact-js/pull/23/files#diff-ad2d27cf5c00ddf29bdafb5718a2a771R108). Might be overkill, thoughts?
|
Nice one, thanks for this |
My take on an updated API that is simpler to use.
pact-karma.js)v2.0.0Almost all of the updated code are tests and documentation, but I see that as a good thing.