Native provider state handlers and request filters #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mefellows
changed the title
|
cc: @lviana-menlosecurity - FYI. |
TimothyJones
approved these changes
Jun 24, 2021
|
OK I think I've resolved most items @TimothyJones. Feedback on the I'll then tidy up commits, sync up with |
mefellows
force-pushed
the
fix/provider-state-handlers
branch
from
665a3ff to
b5e8638
Compare
Adds back the proxy infrastructure to allow native promises in the request filters and provider state handlers. BREAKING CHANGE: the signature of state handlers has been updated to accept either a single function with parameters, or an object that can specify optional teardown and setup functions that run on the different state phases. BREAKING CHANGE: callbackTimeout is now timeout
mefellows
force-pushed
the
fix/provider-state-handlers
branch
from
691cdf2 to
456567c
Compare
|
Going to merge this in. Now that it's here, adding support for messages is actually not a huge amount of work either. |
|
Awesome! Excited about this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main changes:
setupandparams. The response type now expects a Promise.Notably, the states (consumer) and state handlers (provider) now use the
JsonMaptype is outgoing/incoming. I think this is correct.Opening as WIP for feedback, I'll squash it all before merging.
EDIT: check is failing due to code coverage. I can improve testing of some of the v3 interfaces, but let's get ✅ on the general approach first.