Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: demonstrate working local branch (will not work on CI) #710

Merged

Conversation

mefellows
Copy link
Member

@mefellows mefellows commented Jul 17, 2021

Fix for #633 .

Currently does not actually fix it, but has the latest Rust code integrated and compiling.

@uglyog
Copy link
Member

uglyog commented Jul 18, 2021

It works for me (with the published crates):

[2021-07-18T07:21:41Z DEBUG pact_matching::models::generators] apply_body_generators: JSON content type
[2021-07-18T07:21:41Z DEBUG pact_models::generators] Applying generator ProviderStateGenerator("${accountNumber}", None) to key $.accountNumber
[2021-07-18T07:21:41Z DEBUG pact_models::generators] Generating value from ProviderStateGenerator("${accountNumber}", None) with context {"accountNumber": Number(10832)}
[2021-07-18T07:21:41Z DEBUG pact_models::generators] Generated value = Ok(Number(10832))

@mefellows
Copy link
Member Author

Thanks Ron! I'll take a look shortly.

@mefellows
Copy link
Member Author

Looks great, thanks Ron.

@mefellows mefellows force-pushed the fix/accept-non-string-datatypes-fromProviderState branch from 6da6bea to 01d6a34 Compare July 18, 2021 11:49
@mefellows mefellows marked this pull request as ready for review July 18, 2021 11:59
@mefellows mefellows merged commit ec9192f into feat/v3.0.0 Jul 18, 2021
@mefellows mefellows deleted the fix/accept-non-string-datatypes-fromProviderState branch July 18, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants