Cryptocurrency mining references found in source code

[palotasb-booking]

Hi, can you explain the hardcoded references to miningmadness.com introduced in edb04a4 ("fix: revert some changes due to GH Windows agents #405")? That's a crypto mining website: https://wheretomine.io/pools/miningmadness

CC @rholshausen

[SchulteMarkus]

looooool

[YOU54F]

Some background reading. It comes from the /etc/hosts file on GH actions runners. On windows agents, it is in a different case

square/okhttp#6811
actions/runner-images#3353

I imagine it was causing some issues in the windows CI runs

[rholshausen]

That change is making sure that if the local host reverse lookup ever resolves to that site, don't use it!

[palotasb-booking]

Thank you for your kind answers @YOU54F and @rholshausen. So do I understand correctly that your code reads all the domains listed in /etc/hosts (at least in some GitHub Actions), one of which is with some upper-case letters MiningMadness.com? This has caused issues (because of the upper-case letters), and the change we noticed is trying to fix this issue? Please correct me if I misunderstand.

Is there a way to solve that issue without hard-coding miningmadness.com in the source code? Perhaps by lower-casing the input domains in general and not just this specific one or by ignoring all non-lower-case domains? It's super-suspicious the way it's currently implemented.