Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Malformed /etc/hosts. #3353

Closed
1 of 7 tasks
igsilya opened this issue May 10, 2021 · 5 comments
Closed
1 of 7 tasks

Malformed /etc/hosts. #3353

igsilya opened this issue May 10, 2021 · 5 comments
Assignees
@al-cheb
Labels
Area: Image administration

Comments

@igsilya
Copy link

igsilya commented May 10, 2021

Description
/etc/hosts file contains following:

127.0.0.1 localhost

# The following lines are desirable for IPv6 capable hosts
::1     localhost ip6-localhost ip6-loopback
fe00::0 ip6-localnet
ff00::0 ip6-mcastprefix
ff02::1 ip6-allnodes
ff02::2 ip6-allrouters
ff02::3 ip6-allhosts
Note: Don't Delete this file. Also, don't remove this line. And empty file will break pool provisioning.
127.0.0.1 cpu-pool.com
127.0.0.1 MiningMadness.com
127.0.0.1 stratum-na.rplant.xyz
127.0.0.1 do-dear.com
127.0.0.1 web.do-dear.com
127.0.0.1 git.workflows.live
10.1.0.62 fv-az50-195.grzltbmokehuzjyc5b133kdqgh.cx.internal.cloudapp.net fv-az50-195

The Note: ... line is not a valid line for this file and it breaks libunbound that is no longer able to parse this file.
This breaks unit tests at least for openvswitch project.

Area for Triage:

Question, Bug, or Feature?:

Bug

Virtual environments affected

  • Ubuntu 16.04
  • Ubuntu 18.04
  • Ubuntu 20.04
  • macOS 10.15
  • macOS 11.0
  • Windows Server 2016 R2
  • Windows Server 2019

Image version

20210504.1

Expected behavior
There should be no extra text in /etc/hosts. At least, it should be a comment, not just a text.

Actual behavior
libunbound is broken, not able to parse the /etc/hosts.

Repro steps
Failed unit tests for openvswitch project:
https://github.com/ovsrobot/ovs/runs/2547843800
@al-cheb al-cheb self-assigned this May 11, 2021
@al-cheb
Copy link
Contributor

al-cheb commented May 11, 2021

Hi, @igsilya
We will take a look at this soon.

@dceara
Copy link

dceara commented May 11, 2021

This also affects Ubuntu 20.04 virtual environments, e.g.:
https://github.com/ovn-org/ovn/runs/2555280189?check_suite_focus=true#step:12:5735

igsilya added a commit to igsilya/ovn that referenced this issue May 11, 2021
@igsilya
github: Fix up malformed /etc/hosts.
62df4c0 
For some reason /etc/hosts in GHA now contains a plain text line
like this:

  Note: Don't Delete this file. Also, don't remove this line. ...

This breaks libunbound and makes a series of unit tests to emit
following warning:
  |00001|dns_resolve|WARN|Failed to read etc/hosts: syntax error

Working around this issue by removing a bad line from /etc/hosts
until this fixed properly by GitHub team.

Bug for virtual-environments:
  actions/runner-images#3353

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
ovsrobot pushed a commit to ovsrobot/ovs that referenced this issue May 11, 2021
@igsilya @ovsrobot
github: Fix up malformed /etc/hosts.
a5977d3 
For some reason /etc/hosts in GHA now contains a plain text line
like this:

  Note: Don't Delete this file. Also, don't remove this line. ...

This breaks libunbound and makes a series of unit tests to emit
following warning:
  |00001|dns_resolve|WARN|Failed to read etc/hosts: syntax error

Working around this issue by removing a bad line from /etc/hosts
until this fixed properly by GitHub team.  This in combination
with other fixes should unblock CI.

Bug for virtual-environments:
  actions/runner-images#3353

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: 0-day Robot <robot@bytheb.org>
igsilya added a commit to igsilya/ovs that referenced this issue May 11, 2021
@igsilya
github: Fix up malformed /etc/hosts.
085f0fd 
For some reason /etc/hosts in GHA now contains a plain text line
like this:

  Note: Don't Delete this file. Also, don't remove this line. ...

This breaks libunbound and makes a series of unit tests to emit
following warning:
  |00001|dns_resolve|WARN|Failed to read etc/hosts: syntax error

Working around this issue by removing a bad line from /etc/hosts
until this fixed properly by GitHub team.  This in combination
with other fixes should unblock CI.

Bug for virtual-environments:
  actions/runner-images#3353

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Reviewed-by: David Marchand <david.marchand@redhat.com>
igsilya added a commit to igsilya/ovs that referenced this issue May 11, 2021
@igsilya
github: Fix up malformed /etc/hosts.
3ddbb9c 
For some reason /etc/hosts in GHA now contains a plain text line
like this:

  Note: Don't Delete this file. Also, don't remove this line. ...

This breaks libunbound and makes a series of unit tests to emit
following warning:
  |00001|dns_resolve|WARN|Failed to read etc/hosts: syntax error

Working around this issue by removing a bad line from /etc/hosts
until this fixed properly by GitHub team.  This in combination
with other fixes should unblock CI.

Bug for virtual-environments:
  actions/runner-images#3353

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Reviewed-by: David Marchand <david.marchand@redhat.com>
igsilya added a commit to igsilya/ovs that referenced this issue May 11, 2021
@igsilya
github: Fix up malformed /etc/hosts.
5e7e12f 
For some reason /etc/hosts in GHA now contains a plain text line
like this:

  Note: Don't Delete this file. Also, don't remove this line. ...

This breaks libunbound and makes a series of unit tests to emit
following warning:
  |00001|dns_resolve|WARN|Failed to read etc/hosts: syntax error

Working around this issue by removing a bad line from /etc/hosts
until this fixed properly by GitHub team.  This in combination
with other fixes should unblock CI.

Bug for virtual-environments:
  actions/runner-images#3353

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Reviewed-by: David Marchand <david.marchand@redhat.com>
igsilya added a commit to igsilya/ovs that referenced this issue May 11, 2021
@igsilya
github: Fix up malformed /etc/hosts.
61e0a13 
For some reason /etc/hosts in GHA now contains a plain text line
like this:

  Note: Don't Delete this file. Also, don't remove this line. ...

This breaks libunbound and makes a series of unit tests to emit
following warning:
  |00001|dns_resolve|WARN|Failed to read etc/hosts: syntax error

Working around this issue by removing a bad line from /etc/hosts
until this fixed properly by GitHub team.  This in combination
with other fixes should unblock CI.

Bug for virtual-environments:
  actions/runner-images#3353

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Reviewed-by: David Marchand <david.marchand@redhat.com>
igsilya added a commit to igsilya/ovs that referenced this issue May 11, 2021
@igsilya
github: Fix up malformed /etc/hosts.
2bd2f3e 
For some reason /etc/hosts in GHA now contains a plain text line
like this:

  Note: Don't Delete this file. Also, don't remove this line. ...

This breaks libunbound and makes a series of unit tests to emit
following warning:
  |00001|dns_resolve|WARN|Failed to read etc/hosts: syntax error

Working around this issue by removing a bad line from /etc/hosts
until this fixed properly by GitHub team.  This in combination
with other fixes should unblock CI.

Bug for virtual-environments:
  actions/runner-images#3353

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Reviewed-by: David Marchand <david.marchand@redhat.com>
ovsrobot pushed a commit to ovsrobot/ovn that referenced this issue May 11, 2021
@igsilya @ovsrobot
github: Fix up malformed /etc/hosts.
855cca0 
For some reason /etc/hosts in GHA now contains a plain text line
like this:

  Note: Don't Delete this file. Also, don't remove this line. ...

This breaks libunbound and makes a series of unit tests to emit
following warning:
  |00001|dns_resolve|WARN|Failed to read etc/hosts: syntax error

Working around this issue by removing a bad line from /etc/hosts
until this fixed properly by GitHub team.

Bug for virtual-environments:
  actions/runner-images#3353

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Acked-by: Dumitru Ceara <dceara@redhat.com>
Signed-off-by: 0-day Robot <robot@bytheb.org>
numansiddique pushed a commit to ovn-org/ovn that referenced this issue May 11, 2021
@igsilya @numansiddique
github: Fix up malformed /etc/hosts.
ca3e9cd 
For some reason /etc/hosts in GHA now contains a plain text line
like this:

  Note: Don't Delete this file. Also, don't remove this line. ...

This breaks libunbound and makes a series of unit tests to emit
following warning:
  |00001|dns_resolve|WARN|Failed to read etc/hosts: syntax error

Working around this issue by removing a bad line from /etc/hosts
until this fixed properly by GitHub team.

Bug for virtual-environments:
  actions/runner-images#3353

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Acked-by: Dumitru Ceara <dceara@redhat.com>
Signed-off-by: Numan Siddique <numans@ovn.org>
igsilya added a commit to openvswitch/ovs that referenced this issue May 11, 2021
@igsilya
github: Fix up malformed /etc/hosts.
484e9a4 
For some reason /etc/hosts in GHA now contains a plain text line
like this:

  Note: Don't Delete this file. Also, don't remove this line. ...

This breaks libunbound and makes a series of unit tests to emit
following warning:
  |00001|dns_resolve|WARN|Failed to read etc/hosts: syntax error

Working around this issue by removing a bad line from /etc/hosts
until this fixed properly by GitHub team.  This in combination
with other fixes should unblock CI.

Bug for virtual-environments:
  actions/runner-images#3353

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Acked-by: Aaron Conole <aconole@redhat.com>
igsilya added a commit to openvswitch/ovs that referenced this issue May 11, 2021
@igsilya
github: Fix up malformed /etc/hosts.
2145272 
For some reason /etc/hosts in GHA now contains a plain text line
like this:

  Note: Don't Delete this file. Also, don't remove this line. ...

This breaks libunbound and makes a series of unit tests to emit
following warning:
  |00001|dns_resolve|WARN|Failed to read etc/hosts: syntax error

Working around this issue by removing a bad line from /etc/hosts
until this fixed properly by GitHub team.  This in combination
with other fixes should unblock CI.

Bug for virtual-environments:
  actions/runner-images#3353

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Acked-by: Aaron Conole <aconole@redhat.com>
igsilya added a commit to openvswitch/ovs that referenced this issue May 11, 2021
@igsilya
github: Fix up malformed /etc/hosts.
5c9ba8b 
For some reason /etc/hosts in GHA now contains a plain text line
like this:

  Note: Don't Delete this file. Also, don't remove this line. ...

This breaks libunbound and makes a series of unit tests to emit
following warning:
  |00001|dns_resolve|WARN|Failed to read etc/hosts: syntax error

Working around this issue by removing a bad line from /etc/hosts
until this fixed properly by GitHub team.  This in combination
with other fixes should unblock CI.

Bug for virtual-environments:
  actions/runner-images#3353

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Acked-by: Aaron Conole <aconole@redhat.com>
igsilya added a commit to openvswitch/ovs that referenced this issue May 11, 2021
@igsilya
github: Fix up malformed /etc/hosts.
fbebe73 
For some reason /etc/hosts in GHA now contains a plain text line
like this:

  Note: Don't Delete this file. Also, don't remove this line. ...

This breaks libunbound and makes a series of unit tests to emit
following warning:
  |00001|dns_resolve|WARN|Failed to read etc/hosts: syntax error

Working around this issue by removing a bad line from /etc/hosts
until this fixed properly by GitHub team.  This in combination
with other fixes should unblock CI.

Bug for virtual-environments:
  actions/runner-images#3353

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Acked-by: Aaron Conole <aconole@redhat.com>
igsilya added a commit to openvswitch/ovs that referenced this issue May 11, 2021
@igsilya
github: Fix up malformed /etc/hosts.
8dacc52 
For some reason /etc/hosts in GHA now contains a plain text line
like this:

  Note: Don't Delete this file. Also, don't remove this line. ...

This breaks libunbound and makes a series of unit tests to emit
following warning:
  |00001|dns_resolve|WARN|Failed to read etc/hosts: syntax error

Working around this issue by removing a bad line from /etc/hosts
until this fixed properly by GitHub team.  This in combination
with other fixes should unblock CI.

Bug for virtual-environments:
  actions/runner-images#3353

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Acked-by: Aaron Conole <aconole@redhat.com>
@igsilya
Copy link
Author

igsilya commented May 11, 2021

For the time being we worked around this issue by sed -i "/don't remove this line/d" /etc/hosts, but would like to revert this change as soon as the issue fixed.

numansiddique pushed a commit to ovn-org/ovn that referenced this issue May 12, 2021
@igsilya @numansiddique
github: Fix up malformed /etc/hosts.
ae86ad7 
For some reason /etc/hosts in GHA now contains a plain text line
like this:

  Note: Don't Delete this file. Also, don't remove this line. ...

This breaks libunbound and makes a series of unit tests to emit
following warning:
  |00001|dns_resolve|WARN|Failed to read etc/hosts: syntax error

Working around this issue by removing a bad line from /etc/hosts
until this fixed properly by GitHub team.

Bug for virtual-environments:
  actions/runner-images#3353

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Acked-by: Dumitru Ceara <dceara@redhat.com>
Signed-off-by: Numan Siddique <numans@ovn.org>
(cherry picked from commit ca3e9cd)
numansiddique pushed a commit to ovn-org/ovn that referenced this issue May 12, 2021
@igsilya @numansiddique
github: Fix up malformed /etc/hosts.
1018e28 
For some reason /etc/hosts in GHA now contains a plain text line
like this:

  Note: Don't Delete this file. Also, don't remove this line. ...

This breaks libunbound and makes a series of unit tests to emit
following warning:
  |00001|dns_resolve|WARN|Failed to read etc/hosts: syntax error

Working around this issue by removing a bad line from /etc/hosts
until this fixed properly by GitHub team.

Bug for virtual-environments:
  actions/runner-images#3353

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Acked-by: Dumitru Ceara <dceara@redhat.com>
Signed-off-by: Numan Siddique <numans@ovn.org>
(cherry picked from commit ca3e9cd)
odivlad pushed a commit to odivlad/ovn that referenced this issue May 25, 2021
@igsilya @odivlad
github: Fix up malformed /etc/hosts.
4f00ce1 
For some reason /etc/hosts in GHA now contains a plain text line
like this:

  Note: Don't Delete this file. Also, don't remove this line. ...

This breaks libunbound and makes a series of unit tests to emit
following warning:
  |00001|dns_resolve|WARN|Failed to read etc/hosts: syntax error

Working around this issue by removing a bad line from /etc/hosts
until this fixed properly by GitHub team.

Bug for virtual-environments:
  actions/runner-images#3353

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Acked-by: Dumitru Ceara <dceara@redhat.com>
Signed-off-by: Numan Siddique <numans@ovn.org>
This was referenced May 31, 2021
Merged
Closed
gesellix added a commit to docker-client/docker-engine that referenced this issue Jun 5, 2021
@gesellix
Whitelist all aliases for localhost in tests
d8ae6f2 
Relates to actions/runner-images#3353
gesellix added a commit to docker-client/docker-engine that referenced this issue Jun 5, 2021
@gesellix
Whitelist all aliases for localhost in tests
14604d8 
Relates to actions/runner-images#3353
gesellix added a commit to docker-client/docker-engine that referenced this issue Jun 5, 2021
@gesellix
Whitelist all aliases for localhost in tests
89da338 
Relates to actions/runner-images#3353
gesellix added a commit to docker-client/docker-engine that referenced this issue Jun 5, 2021
@gesellix
Whitelist all aliases for localhost in tests
17d5f03 
Relates to actions/runner-images#3353
gesellix added a commit to docker-client/docker-engine that referenced this issue Jun 5, 2021
@gesellix
Whitelist all aliases for localhost in tests
2fded7e 
Relates to actions/runner-images#3353
@al-cheb
Copy link
Contributor

al-cheb commented Jun 9, 2021

@igsilya , The fix has been deployed.

@al-cheb al-cheb closed this as completed Jun 9, 2021
dceara added a commit to dceara/ovs that referenced this issue Oct 8, 2021
@dceara
github: Remove workaround fixing up /etc/hosts.
2e48297 
The issue that was worked around has been fixed in the meantime:
actions/runner-images#3353

Signed-off-by: Dumitru Ceara <dceara@redhat.com>
dceara added a commit to dceara/ovn that referenced this issue Oct 8, 2021
@dceara
github: Remove workaround fixing up /etc/hosts.
9c8e75d 
The issue that was worked around has been fixed in the meantime:
actions/runner-images#3353

Signed-off-by: Dumitru Ceara <dceara@redhat.com>
ovsrobot pushed a commit to ovsrobot/ovs that referenced this issue Oct 8, 2021
@dceara @ovsrobot
github: Remove workaround fixing up /etc/hosts.
8300e71 
The issue that was worked around has been fixed in the meantime:
actions/runner-images#3353

Signed-off-by: Dumitru Ceara <dceara@redhat.com>
Signed-off-by: 0-day Robot <robot@bytheb.org>
ovsrobot pushed a commit to ovsrobot/ovn that referenced this issue Oct 8, 2021
@dceara @ovsrobot
github: Remove workaround fixing up /etc/hosts.
238c36b 
The issue that was worked around has been fixed in the meantime:
actions/runner-images#3353

Signed-off-by: Dumitru Ceara <dceara@redhat.com>
Signed-off-by: 0-day Robot <robot@bytheb.org>
numansiddique pushed a commit to numansiddique/ovn that referenced this issue Oct 8, 2021
@dceara @numansiddique
github: Remove workaround fixing up /etc/hosts.
c812603 
The issue that was worked around has been fixed in the meantime:
actions/runner-images#3353

Signed-off-by: Dumitru Ceara <dceara@redhat.com>
Signed-off-by: Numan Siddique <numans@ovn.org>
david-marchand pushed a commit to david-marchand/ovs that referenced this issue Oct 13, 2021
@dceara @david-marchand
github: Remove workaround fixing up /etc/hosts.
ced6f1f 
The issue that was worked around has been fixed in the meantime:
actions/runner-images#3353

Signed-off-by: Dumitru Ceara <dceara@redhat.com>
igsilya pushed a commit to igsilya/ovs that referenced this issue Nov 8, 2021
@dceara @igsilya
github: Remove workaround fixing up /etc/hosts.
695530d 
The issue that was worked around has been fixed in the meantime:
actions/runner-images#3353

Signed-off-by: Dumitru Ceara <dceara@redhat.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
n-sandeep pushed a commit to ipdk-io/ovs that referenced this issue Jul 12, 2022
@dceara @n-sandeep
github: Remove workaround fixing up /etc/hosts.
bee643c 
The issue that was worked around has been fixed in the meantime:
actions/runner-images#3353

Signed-off-by: Dumitru Ceara <dceara@redhat.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
@YOU54F YOU54F mentioned this issue Feb 6, 2023
Open
@titanism
Copy link

titanism commented Mar 10, 2023 •
edited
Loading

This is still an issue.

Edit: This list is a small subset of all possible attack vectors for things like miners. Can we remove this and have them blocked a different way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@al-cheb al-cheb

Labels
Area: Image administration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@igsilya @dceara @al-cheb @titanism