Pact consumer tests' execution hangs after reaching 200 connection limit of mockServer

[m-aster22]

When running the pact consumer tests, the execution hangs after completing 200 tests (we got 222 tests to run). It seemed a bit odd that it'll stop after 200 tests but found this in the console:

I was able to trace this to the mockServer. It doesn't seem to close the connection after each test. Is there a way to close the connection after each test? Thanks!

[uglyog]

Are you running the 222 tests in the same test class, or as part of a suite of tests?

[m-aster22]

It's a suite of tests. We have around 32 test classes and test execution hangs at the 30th class (where the 201st test is located).

[uglyog]

Thanks, I'll look into this. It might be related to #342, in that the PoolingHttpClientConnectionManager is creating a new connection for every test, while each test class gets it's own mock server.

[uglyog]

This is not an issue with the MockServer, but with the Apache Http PoolingHttpClientConnectionManager. See 2.5. Connection eviction policy of https://hc.apache.org/httpcomponents-client-ga/tutorial/html/connmgmt.html for more information.

At the end of your test, you'll need to call ClientConnectionManager#closeExpiredConnections() or don't use the PoolingHttpClientConnectionManager in your tests (if possible).

[m-aster22]

Thanks, I’ll try this out. I’m not using the PoolingHttpClientConnectionManager in the tests, and I have observed the connection starting when I step into runConsumerTest(pact, config, mockServer -> {} even before it reaches the code inside {}. I thought I saw the PoolingHttpClientConnectionManager Being used in the mockServer which is why I mentioned I was able to trace the issue to the mockServer. Thanks again!

…

On Sun, 3 Jun 2018 at 4:22 PM Ronald Holshausen ***@***.***> wrote: This is not an issue with the MockServer, but with the Apache Http PoolingHttpClientConnectionManager. See 2.5. Connection eviction policy of https://hc.apache.org/httpcomponents-client-ga/tutorial/html/connmgmt.html for more information. At the end of your test, you'll need to call ClientConnectionManager#closeExpiredConnections() or don't use the PoolingHttpClientConnectionManager in your tests (if possible). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#658 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AbEp28hTPLaIOHDiUHWzO1saUw75ns9dks5t42SQgaJpZM4S_mtk> .

[uglyog]

Hmm, now that you mention it, there is a bootup check run from that function. I'll check to see if that is using the PoolingHttpClientConnectionManager.

[uglyog]

I think this is the culprit: https://github.com/DiUS/pact-jvm/blob/master/pact-jvm-consumer/src/main/kotlin/au/com/dius/pact/consumer/MockHttpServer.kt#L200

I'll fix that function to use a better connection manager.

[uglyog]

Fix has been released with version 3.5.18