Merge pull request #624 from tienvx/fix-string-could-not-be-parsed-as…

…-xml fix: Fix 'Exception: String could not be parsed as XML' in xml's consumer test
pact-foundation · Aug 30, 2024 · 55e5d60 · 55e5d60
2 parents 61bc2b3 + 68e4cc4
commit 55e5d60
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/example/xml/consumer/tests/Service/HttpClientServiceTest.php b/example/xml/consumer/tests/Service/HttpClientServiceTest.php
@@ -3,6 +3,7 @@
 namespace XmlConsumer\Tests\Service;
 
 use PhpPact\Consumer\Matcher\Matcher;
+use PhpPact\Consumer\Model\Body\Text;
 use PhpPact\Xml\XmlBuilder;
 use XmlConsumer\Service\HttpClientService;
 use PhpPact\Consumer\InteractionBuilder;
@@ -83,9 +84,7 @@ public function testGetMovies()
  $response
  ->setStatus(200)
  ->addHeader('Content-Type', $matcher->regex('application/xml', 'application\/.*xml'))
- ->setBody(
- json_encode($xmlBuilder)
- );
+ ->setBody(new Text(json_encode($xmlBuilder), 'application/xml'));
 
  $config = new MockServerConfig();
  $config

diff --git a/src/PhpPact/Consumer/Driver/InteractionPart/ResponseDriver.php b/src/PhpPact/Consumer/Driver/InteractionPart/ResponseDriver.php
@@ -9,10 +9,8 @@ class ResponseDriver extends AbstractInteractionPartDriver implements ResponseDr
 {
  public function registerResponse(Interaction $interaction): void
  {
- // @todo Fix 'Exception: String could not be parsed as XML' in xml's consumer test
- // when calling `withBody` before `withHeaders`
- $this->withHeaders($interaction, InteractionPart::RESPONSE);
  $this->withBody($interaction, InteractionPart::RESPONSE);
+ $this->withHeaders($interaction, InteractionPart::RESPONSE);
  $this->withResponse($interaction);
  }