Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong content type in protobuf plugin 0.5 #623

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Aug 29, 2024

Fix this error if using protobuf plugin version 0.5 (not sure about 0.4)

expected a body of 'application/protobuf;message=.library.Person' but the actual content type was 'application/protobuf;message=Person'

I guess the .library. and .plugins. prefixes come from the package library; and package plugins; in proto files.

Depend on #622

@tienvx tienvx requested a review from YOU54F August 29, 2024 11:27
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10614134265

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.313%

Totals Coverage Status
Change from base Build 10611257072: 0.0%
Covered Lines: 2282
Relevant Lines: 2345

💛 - Coveralls

@YOU54F
Copy link
Member

YOU54F commented Aug 29, 2024

yep issue is from 0.5.0 onwards following an update

https://github.com/pactflow/pact-protobuf-plugin/releases/tag/v-0.5.0

@tienvx tienvx merged commit 01caab5 into pact-foundation:master Aug 29, 2024
27 of 29 checks passed
@tienvx tienvx deleted the fix-wrong-content-type-in-protobuf-plugin-0.5 branch August 29, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants