Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dont allow null as example value #701

Merged

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Dec 3, 2024

Just replace null with any valid value.
If there is a generator, the valid value will be replaced.

Depend on #696

@tienvx tienvx force-pushed the dont-allow-null-as-example-value branch 2 times, most recently from f14d259 to 67c577d Compare December 3, 2024 02:27
@coveralls
Copy link

coveralls commented Dec 3, 2024

Pull Request Test Coverage Report for Build 12131890788

Details

  • 75 of 75 (100.0%) changed or added relevant lines in 12 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 96.275%

Totals Coverage Status
Change from base Build 12130132873: -0.03%
Covered Lines: 2559
Relevant Lines: 2658

💛 - Coveralls

@tienvx tienvx merged commit 42e2dd0 into pact-foundation:master Dec 14, 2024
20 checks passed
@tienvx tienvx deleted the dont-allow-null-as-example-value branch December 14, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants