Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix PHPStan no error to ignore #709

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix: Fix PHPStan no error to ignore #709

merged 1 commit into from
Dec 20, 2024

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Dec 19, 2024

PHPStan 2.0.4 introduce new change that don't report the error offsetAccess.nonOffsetAccessible on PHP's CDATA anymore.

@tienvx tienvx requested review from JP-Ellis and YOU54F December 19, 2024 23:37
@tienvx tienvx mentioned this pull request Dec 19, 2024
Open
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12422615363

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.313%
Totals Coverage Status
Change from base Build 12368454331: 0.0%
Covered Lines: 2560
Relevant Lines: 2658
💛 - Coveralls

@tienvx tienvx merged commit 4528ed9 into pact-foundation:master Dec 20, 2024
20 checks passed
@tienvx tienvx deleted the fix-phpstan-no-error-to-ignore branch December 20, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JP-Ellis JP-Ellis JP-Ellis approved these changes

@YOU54F YOU54F Awaiting requested review from YOU54F

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tienvx @coveralls @JP-Ellis