Filename plugin.proto is too generic, leading to conflict

[ringods]

I just bumped into this error, using pact-go together with the Go pulumi sdk, both registering plugin.proto:

panic: proto: file "plugin.proto" is already registered
        previously from: "github.com/pact-foundation/pact-go/v2/internal/native"
        currently from:  "github.com/pulumi/pulumi/sdk/v3/proto/go"
See https://developers.google.com/protocol-buffers/docs/reference/go/faq#namespace-conflict

Although both files have different go_package directives, as you can see here:

• https://github.com/pulumi/pulumi/blob/master/sdk/proto/plugin.proto
• https://github.com/pact-foundation/pact-plugins/blob/f0fdfefef0099518635329a6deab424961690b62/proto/plugin.proto

this doesn't seem to be enough. The filenames need to be unique as well, according this comment:

golang/protobuf#1122 (comment)

I’m from Pulumi and will submit a PR to change our filenames, but I strongly suggest to that you also rename your file to e.g. pact-plugin.proto or pact/plugin.proto to prevent future filename collisions. Since protobuf-go v1.26, such a filename collision generates a panic.

[mefellows]

Thanks for reporting @ringods - I've just pushed out a fix to Pact Go now: pact-foundation/pact-go@60aaec1.

[ringods]

Fixed at Pulumi side with pulumi/pulumi#10074