Skip to content

Commit

Permalink
chore(v3)!: remove unnecessary underscores
Browse files Browse the repository at this point in the history
The arguments to `__exit__` are not used. When first implemented, this
used the leading underscores to make that explicit; however, this is
incompatible with the expected type signature of the function.

BREAKING CHANGE: The PactServer `__exit__` arguments no longer have
    leading underscores. This is typically handled by Python itself and
    therefore is unlikely to be a change for any user, unless the end
    user was calling the `__exit__` method explicitly _and_ using
    keyword arguments.

Signed-off-by: JP-Ellis <josh@jpellis.me>
  • Loading branch information
JP-Ellis committed Nov 28, 2024
1 parent b5d5b03 commit 1db2de1
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/pact/v3/pact.py
Original file line number Diff line number Diff line change
Expand Up @@ -744,9 +744,9 @@ def __enter__(self) -> Self:

def __exit__(
self,
_exc_type: type[BaseException] | None,
_exc_value: BaseException | None,
_traceback: TracebackType | None,
exc_type: type[BaseException] | None,
exc_value: BaseException | None,
traceback: TracebackType | None,
) -> None:
"""
Stop the server.
Expand Down

0 comments on commit 1db2de1

Please sign in to comment.