Skip to content

Conversation

@JP-Ellis
Copy link
Contributor

@JP-Ellis JP-Ellis commented Dec 4, 2025

📝 Summary

There was some redundancy with the content type being specified twice, when it isn't really required.

🚨 Breaking Changes

🔥 Motivation

🔨 Test Plan

🔗 Related issues/PRs

Signed-off-by: JP-Ellis <josh@jpellis.me>
@JP-Ellis JP-Ellis self-assigned this Dec 4, 2025
Copilot AI review requested due to automatic review settings December 4, 2025 22:03
@JP-Ellis JP-Ellis enabled auto-merge (rebase) December 4, 2025 22:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a redundant Content-Type header specification from a code example in the Pact Python v3 release blog post. The Content-Type is already being set via the content_type parameter in the with_body() method, making the explicit header declaration unnecessary.

Key Changes

  • Removed duplicate Content-Type header declaration from code example
Comments suppressed due to low confidence (1)

docs/blog/posts/2025/12-04 pact-python-v3-release.md:1

  • The blog post filename and content reference December 4, 2025, which is a future date. Since the current date is December 4, 2025, this appears to be published today. Verify this is intentional and the content is ready for publication.
---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51%. Comparing base (8bd7657) to head (4062d41).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@         Coverage Diff          @@
##           main   #1385   +/-   ##
====================================
  Coverage    51%     51%           
====================================
  Files        31      31           
  Lines      3729    3729           
====================================
  Hits       1938    1938           
  Misses     1791    1791           
Flag Coverage Δ
tests 51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JP-Ellis JP-Ellis merged commit 63d8ec6 into main Dec 4, 2025
59 checks passed
@JP-Ellis JP-Ellis deleted the docs/remove-redundant-header branch December 4, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants