Skip to content

Conversation

@JP-Ellis
Copy link
Contributor

📝 Summary

Switch from hatch-vcs to versioningit.

🚨 Breaking Changes

🔥 Motivation

I have been finding hatch-vcs (built on top of setuptools-scm) to be a bit too finicky.

🔨 Test Plan

🔗 Related issues/PRs

@JP-Ellis JP-Ellis self-assigned this Dec 10, 2025
Copilot AI review requested due to automatic review settings December 10, 2025 03:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the versioning system from hatch-vcs (based on setuptools-scm) to versioningit across three Python packages in the repository. The change aims to address reliability issues experienced with hatch-vcs.

Key changes:

  • Replaced hatch-vcs with versioningit in build dependencies
  • Simplified version configuration by removing complex git describe commands and raw options
  • Added versioningit configuration sections with tag matching, prefix removal, and version file generation

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
pyproject.toml Migrated main pact-python package to versioningit, removed hatch-vcs from dependencies and dev environment
pact-python-ffi/pyproject.toml Migrated pact-python-ffi package to versioningit with appropriate tag matching pattern
pact-python-cli/pyproject.toml Migrated pact-python-cli package to versioningit with appropriate tag matching pattern

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52%. Comparing base (8009ddb) to head (c785c67).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@         Coverage Diff          @@
##           main   #1397   +/-   ##
====================================
  Coverage    51%     52%           
====================================
  Files        31      32    +1     
  Lines      3729    3805   +76     
====================================
+ Hits       1938    2000   +62     
- Misses     1791    1805   +14     
Flag Coverage Δ
tests 52% <ø> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JP-Ellis JP-Ellis force-pushed the chore/switch-to-versioningit branch 6 times, most recently from 0b96a2a to 9b86be5 Compare December 10, 2025 06:24
I have been finding hatch-vcs (built on top of setuptools-scm) to be a
bit too finicky, so I am switching to versioningit.

Signed-off-by: JP-Ellis <josh@jpellis.me>
@JP-Ellis JP-Ellis force-pushed the chore/switch-to-versioningit branch from 9b86be5 to c785c67 Compare December 10, 2025 06:40
@JP-Ellis JP-Ellis merged commit 2f43c92 into main Dec 10, 2025
59 checks passed
@JP-Ellis JP-Ellis deleted the chore/switch-to-versioningit branch December 10, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants