Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Reuse matching rules and generators processing code #345

Merged
merged 1 commit into from
Nov 21, 2023
Merged

refactor: Reuse matching rules and generators processing code #345

merged 1 commit into from
Nov 21, 2023

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Nov 21, 2023

Reuse code to:

  • Support nested matching rules and generators instead of single level
  • Support any types for metadata's value, not just string
  • Fix null when pact:matcher:type is not set in JSON object e.g. JSON: { "ID": "sjhdjkshsdjh", "weight": 100.5 }

@rholshausen rholshausen merged commit aaa0157 into pact-foundation:master Nov 21, 2023
16 checks passed
@tienvx tienvx deleted the reuse-matching-rules-processing-code branch November 22, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tienvx @rholshausen