Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provide configuration for build url to be published in verification results #252

Conversation

konalegi
Copy link
Contributor

Thanks for the awesome project!

This PR adds a configuration option to add buildUrl into verification results, which could be added later as a webhook param in pact broker.

@bethesque
Copy link
Member

Thanks so much. Sorry for the slow reply - I've been on leave or a few glorious weeks. Have you tested this manually successfully?

@konalegi
Copy link
Contributor Author

konalegi commented Jan 26, 2022

@bethesque yes, tested that locally. (sorry for a long reply, missed your message)

@konalegi
Copy link
Contributor Author

@bethesque please take a look. thanks!

@bethesque bethesque merged commit ce1c9bc into pact-foundation:master Feb 24, 2022
@bethesque
Copy link
Member

Sorry it's taken me so long. I'll have it out asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants