feat: relax rack-test dependency to allow version 2 #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rack-test has a number of fixes and improvements: https://github.com/rack/rack-test/blob/main/History.md
|
See #271 |
|
Sorry, see #268 |
|
As far as I can tell, there shouldn't be any issues with this update: #268 (comment) |
|
What I'll do is open up the version for ruby, but lock it for the pact-ruby-standalone, so if there are any impacts, the ruby people will find them first! |
|
For what it is worth I have implemented a producer and consumer using rack-test 2.X from my branch and didn't encounter any issues. |
|
Locked rack-test in pact-ruby-standalone pact-foundation/pact-ruby-standalone@3fc12c9 |
|
Also in pact-cli pact-foundation/pact-ruby-cli@b558532 |
|
New version of pact gem released with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rack-test has a number of fixes and improvements:
https://github.com/rack/rack-test/blob/main/History.md