Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CI): use setup-ruby's bundle installer and cache #275

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

josephyi
Copy link
Contributor

@josephyi josephyi commented Oct 2, 2022

  • use setup-ruby to run bundle install
  • refactor BUNDLE_GEMFILE to the job level

Test runs with these changes can be observed here - https://github.com/josephyi/pact-ruby/actions/workflows/test.yml

@bethesque
Copy link
Member

Why is the BUNDLE_GEMFILE: active-support.gemfile removed?

@bethesque
Copy link
Member

Oh, I see! Sorry, was not reading properly.

@bethesque bethesque merged commit f5621b6 into pact-foundation:master Oct 4, 2022
@bethesque
Copy link
Member

Thanks!

I only realised after I'd pressed the "merge" button, but this is a "chore" not a "feat". "feat" is only for things that affect the user and should be included in release notes.

@josephyi
Copy link
Contributor Author

josephyi commented Oct 4, 2022

Thanks!

I only realised after I'd pressed the "merge" button, but this is a "chore" not a "feat". "feat" is only for things that affect the user and should be included in release notes.

Ooh sorry about that, makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants