-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared Libraries #47
Comments
Right, so Ubuntu defaults to openssl 3.x.x. Should we consider not using openssl in that library @uglyog and instead use the rust tls stuff like we're using elsewhere? What's the broader impact of dropping openssl? |
The only issue was the certificate loading issue on Windows, but that is now resolved |
I Guess my confusion here is. Why is Linux client requiring OpenSSL if windows is not? I Just verified @rholshausen is correct; however my windows machine is a pet machine, not deployed with infrastructure as code. So It's very possible that some other dependency brings in OpenSSL. I'll try to ask my wife who is not a coder to try this. Because if it's not an issue for Windows, I can't see why it should be an issue for Linux... Are the builds so different? Update: https://github.com/pact-foundation/pact-stub-server/blob/master/Cargo.lock#L814-L830 |
On Windows and OSX there are OS specific APIs to provide TLS, on Linux it has to use openssl. From: https://github.com/sfackler/rust-native-tls
By default, openssl will be dynamically linked on Linux. |
Just looking for how to statically link openssl then following sfackler/rust-native-tls#190 (comment) |
OpenSSL as always... not fun to play with smol attempt. I wonder if https://github.com/rustls/rustls might drop in with less fuss... I'll try to make some time on this at some point, but it can't be a priority for me at the moment (sorry). How likely is this library/utility to be maintained in the future? I noticed master mentions an unpublished release that didn't pass github actions on mac, and hasn't updated since Jan 2021... Is this repo deprecated? One other approach that could work would be (maintenance burden), maintaining a generic docs warning for Linux users, with specific community contributed guides to setting up openssl and crypto shared objects of the correct version. |
I have migrated the other Rust-based Pact utilities to use Rust TLS, so it won't be a big change. I just haven't had the time to get around to this one. But it is still supported. |
The binary is now only linked to the standard Linux libs
|
Awesome, I'll take https://github.com/pact-foundation/pact-stub-server/releases/tag/v0.5.0 for a spin. Should definitely be more stable than shell scripts. |
Just tried running this on Ubuntu 22.04
First it says
libssl.so.1.1
is missing (the system default is libssl.so)Then
libcrypto.so.1.1
. Same behhavior...I'd installed something that put these into snap packages, so I copied from
/snap/core20/1434/usr/lib/x86_64-linux-gnu/libcrypto.so.1.1
to/usr/lib/x86_64-linux-gnu/libcrypto.so.1.1
(same with libssl.so.1.1)
Seems like this should either ship with those or link to something that can be statically compiled in.
The text was updated successfully, but these errors were encountered: