Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transport switch in flag start pactus-daemon #1675

Open
Ja7ad opened this issue Jan 23, 2025 · 0 comments · May be fixed by #1681
Open

Add transport switch in flag start pactus-daemon #1675

Ja7ad opened this issue Jan 23, 2025 · 0 comments · May be fixed by #1681
Labels
enhancement New feature or request good first issue Good for newcomers Pactus-Daemon
Milestone

Comments

@Ja7ad
Copy link
Contributor

Ja7ad commented Jan 23, 2025

Describe the problem you'd like to have solved

Currently, enabling transport options such as gRPC, gRPC-Gateway, JSON-RPC, ZeroMQ, etc., requires manually editing config.toml before running pactus-daemon.

Describe the ideal solution

We can introduce command-line flags for the start command to enable these transports dynamically.

For example:

$ pactus-daemon start --grpc localhost:50051 --grpc-wallet --json-rpc localhost:5132 --zmq-tx-info-publisher tcp://*:50238

These switches have no effect on the configuration.

This is suggested switchs:

  • --grpc to enable grpc transport (address:port as string).
  • --grpc-wallet to enable wallet service in grpc (boolean).
  • --zmq-block-info to enable zeromq block info publisher (tcp://address:port as string).
  • --zmq-tx-info to enable zeromq tx info publisher (tcp://address:port as string).
  • --zmq-raw-block to enable zeromq block raw publisher (tcp://address:port as string).
  • --zmq-raw-tx to enable zeromq tx raw publisher (tcp://address:port as string).
@Ja7ad Ja7ad added enhancement New feature or request good first issue Good for newcomers Pactus-Daemon labels Jan 23, 2025
@Ja7ad Ja7ad added this to the v1.8.0 milestone Jan 23, 2025
@Ja7ad Ja7ad linked a pull request Feb 2, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Pactus-Daemon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant