feat(cmd): add transport switch in flag start daemon #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ja7ad
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1681 +/- ##
==========================================
+ Coverage 75.07% 76.34% +1.26%
==========================================
Files 234 242 +8
Lines 12156 18620 +6464
==========================================
+ Hits 9126 14215 +5089
- Misses 2582 3943 +1361
- Partials 448 462 +14 |
|
I feel we can simplify it even further. Instead of defining a modifier per config, we could have a function like |
b00f
requested changes
Feb 6, 2025
| ) { | ||
| conf, gen, err := MakeConfig(workingDir) | ||
| func StartNode(workingDir string, passwordFetcher func(*wallet.Wallet) (string, bool), | ||
| confModifiers ...config.Modifier, |
There was a problem hiding this comment.
Suggested change
| confModifiers ...config.Modifier, | |
| modifier func(*config.Config) *config.Config, |
There was a problem hiding this comment.
@b00f Why modifier return Config? Modifier just applied changes on loaded configuration.
| @@ -498,6 +498,10 @@ func MakeConfig(workingDir string) (*config.Config, *genesis.Genesis, error) { | |||
| conf.WalletManager.ChainType = chainType | |||
| conf.WalletManager.WalletsDir = walletsDir | |||
|
|
|||
| for _, modify := range confModifiers { | |||
There was a problem hiding this comment.
if modifier != nil {
conf = modifier(conf)
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add transport switch in flag start pactus-daemon.
Related issue(s)