fix: prevent data race conditions in committee #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #452 +/- ##
==========================================
- Coverage 82.53% 82.50% -0.03%
==========================================
Files 149 149
Lines 6992 6975 -17
==========================================
- Hits 5771 5755 -16
- Misses 932 933 +1
+ Partials 289 287 -2 |
themantre
approved these changes
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent data race conditions in committee by cloning validators.
This commit addresses a potential data race condition that can occur when a validator inside the committee updates. To prevent this, we now clone validators. This ensures that the original validators are not modified and eliminates the possibility of data race conditions.