-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sort wallet addresses #836
Merged
amirvalhalla
merged 10 commits into
pactus-project:main
from
amirvalhalla:feat-sort-addresses
Dec 6, 2023
Merged
feat: sort wallet addresses #836
amirvalhalla
merged 10 commits into
pactus-project:main
from
amirvalhalla:feat-sort-addresses
Dec 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirvalhalla
changed the title
Feat: sort addresses of wallet
feat:sort wallet addresses
Dec 4, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #836 +/- ##
==========================================
- Coverage 83.37% 83.17% -0.20%
==========================================
Files 170 170
Lines 8492 8572 +80
==========================================
+ Hits 7080 7130 +50
- Misses 1083 1101 +18
- Partials 329 341 +12 |
b00f
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
implement sorting wallet addresses based on PIP-8 and PIP-13