chore: lint

internal/controllers/terraformlayer/run.go

@@ -5,7 +5,6 @@ import (
 	"fmt"
 	"sort"
 	"sync"
-	"time"
 
 	configv1alpha1 "github.com/padok-team/burrito/api/v1alpha1"
 	log "github.com/sirupsen/logrus"
@@ -83,11 +82,6 @@ func (r *Reconciler) getAllFinishedRuns(ctx context.Context, layer *configv1alph
 	return runs, nil
 }
 
-type runRetention struct {
-	plan  time.Duration
-	apply time.Duration
-}
-
 func deleteAll(ctx context.Context, c client.Client, objs []*configv1alpha1.TerraformRun) error {
 	var wg sync.WaitGroup
 	errorCh := make(chan error, len(objs))
@@ -161,7 +155,7 @@ func sortAndSplitRunsByAction(runs []*configv1alpha1.TerraformRun) map[string][]
 		}
 		splittedRuns[run.Spec.Action] = append(splittedRuns[run.Spec.Action], run)
 	}
-	for action, _ := range splittedRuns {
+	for action := range splittedRuns {
 		sort.Slice(splittedRuns[action], func(i, j int) bool {
 			return splittedRuns[action][i].CreationTimestamp.Before(&splittedRuns[action][j].CreationTimestamp)
 		})

internal/server/api/layers.go

@@ -63,7 +63,11 @@ func (a *API) isLayerRunning(layer configv1alpha1.TerraformLayer) bool {
 		log.Errorf("could not list terraform runs, returning false: %s", err)
 		return false
 	}
-	a.Client.List(context.Background(), runs)
+	err = a.Client.List(context.Background(), runs)
+	if err != nil {
+		log.Errorf("could not list terraform runs, returning false: %s", err)
+		return false
+	}
 	for _, r := range runs.Items {
 		if r.Status.State == "Running" {
 			return true
@@ -73,8 +77,5 @@ func (a *API) isLayerRunning(layer configv1alpha1.TerraformLayer) bool {
 }
 
 func (a *API) isLayerPR(layer configv1alpha1.TerraformLayer) bool {
-	if layer.OwnerReferences[0].Kind == "TerraformPullRequest" {
-		return true
-	}
-	return false
+	return layer.OwnerReferences[0].Kind == "TerraformPullRequest"
 }

internal/server/server.go

@@ -55,8 +55,9 @@ func (s *Server) Exec() {
 	if err != nil {
 		log.Fatalf("error initializing client: %s", err)
 	}
-	s.API.Client = *client
-	s.Webhook.Client = *client
+	s.client = *client
+	s.API.Client = s.client
+	s.Webhook.Client = s.client
 	log.Infof("starting burrito server...")
 	e := echo.New()
 	e.Use(middleware.Logger())