Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layer): handle terraform errors in runner #149

Merged
merged 13 commits into from
Aug 3, 2023
Merged

Conversation

corrieriluca
Copy link
Member

@corrieriluca corrieriluca commented Aug 2, 2023

Closes #148

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Merging #149 (7bd006f) into main (6f45c0b) will increase coverage by 0.16%.
The diff coverage is 68.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   69.67%   69.84%   +0.16%     
==========================================
  Files          23       23              
  Lines        1560     1572      +12     
==========================================
+ Hits         1087     1098      +11     
- Misses        411      412       +1     
  Partials       62       62              
Files Changed Coverage Δ
...nal/controllers/terraformpullrequest/controller.go 34.92% <0.00%> (ø)
...nternal/controllers/terraformpullrequest/states.go 56.97% <0.00%> (ø)
internal/webhook/github/provider.go 69.64% <0.00%> (ø)
internal/webhook/gitlab/provider.go 71.66% <0.00%> (ø)
internal/burrito/config/config.go 61.76% <20.00%> (-0.93%) ⬇️
internal/controllers/terraformlayer/conditions.go 65.10% <100.00%> (+1.32%) ⬆️
internal/controllers/terraformlayer/pod.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@corrieriluca corrieriluca force-pushed the fix/runner-tf-failure branch 2 times, most recently from fadbb45 to f7a0636 Compare August 2, 2023 14:18
@corrieriluca corrieriluca force-pushed the fix/runner-tf-failure branch from 7bd006f to c9d00ca Compare August 3, 2023 10:30
@corrieriluca corrieriluca marked this pull request as ready for review August 3, 2023 10:31
@corrieriluca corrieriluca added this to the v0.2.0 milestone Aug 3, 2023
Copy link
Contributor

@spoukke spoukke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@spoukke spoukke merged commit 833c77e into main Aug 3, 2023
@spoukke spoukke mentioned this pull request Aug 3, 2023
@corrieriluca corrieriluca deleted the fix/runner-tf-failure branch November 4, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle Terraform failure in runner
3 participants