Display Error Message When Generator Template Cannot Be Loaded. #2153
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've updated this with a fix for the underlying Thor issue. There are a couple ways to fix this, let me know if you'd prefer a different approach. |
This version of prevents http templates from being loaded. See rails/thor#576
|
Merged manually with a fix eeab412 |
|
What about the fix for Thor, which is the true fix for #2152? |
|
What about it? We use 'open-uri' in and I fixed it. |
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE: #2152
(not real fix though 😿).Not sure that the code fixed in 49f296a is even used.