Upgrade purescript-react 5 #94
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Needed to add resolution for purescript-react since purescript-react-dom 4 uses an older version
* div wrapper is no longer required
Author
|
Removed bower resolution since purescript-react-dom was updated |
Closed
|
just wondering how much longer / what's left to do before this one gets in? |
Owner
|
I'm planning to come back to review all of the open Thermite PRs soon. |
Collaborator
|
@jvliwanag version v6.x of thermite now supports react v16.x and purescript-react v6.x, and purs v0.12.x. Sorry this took so long! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Or should probably hold this off until purescript-react-dom is updated - purescript-contrib/purescript-react-dom#10