Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --extra-header argument not working #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

szilard-dobai
Copy link

Puppeteer expects to receive the extra HTTP headers as an object, not an array of objects.

Before this fix, trying to run the CLI with an --extra-header argument would throw with the following error:

➜  pagedjs-cli http://www.google.com --extra-header xx:xx

◶ Loading: http://www.google.comfile:///Users/szilarddobai/.nvm/versions/node/v20.15.1/lib/node_modules/pagedjs-cli/node_modules/puppeteer-core/lib/esm/puppeteer/util/assert.js:25
        throw new Error(message);
              ^

Error: Expected value of header "0" to be String, but "object" is found.
    at assert (file:///Users/szilarddobai/.nvm/versions/node/v20.15.1/lib/node_modules/pagedjs-cli/node_modules/puppeteer-core/lib/esm/puppeteer/util/assert.js:25:15)
    at NetworkManager.setExtraHTTPHeaders (file:///Users/szilarddobai/.nvm/versions/node/v20.15.1/lib/node_modules/pagedjs-cli/node_modules/puppeteer-core/lib/esm/puppeteer/common/NetworkManager.js:106:13)
    at CDPPage.setExtraHTTPHeaders (file:///Users/szilarddobai/.nvm/versions/node/v20.15.1/lib/node_modules/pagedjs-cli/node_modules/puppeteer-core/lib/esm/puppeteer/common/Page.js:448:50)
    at Printer.render (file:///Users/szilarddobai/.nvm/versions/node/v20.15.1/lib/node_modules/pagedjs-cli/src/printer.js:86:9)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Printer.pdf (file:///Users/szilarddobai/.nvm/versions/node/v20.15.1/lib/node_modules/pagedjs-cli/src/printer.js:270:14)
    at async file:///Users/szilarddobai/.nvm/versions/node/v20.15.1/lib/node_modules/pagedjs-cli/src/cli.js:172:10

Puppeteer expects to receive the extra HTTP headers as an object, not an array of objects.
@szilard-dobai szilard-dobai changed the title Fix --extra-header argument not working Fix --extra-header argument not working Nov 15, 2024
@szilard-dobai
Copy link
Author

Hey there @fchasen! I was hoping you could take a look over this when you have a chance? I'm having some troubles setting up puppeteer to work for larger webpages when trying to print to PDF, but found this CLI works great. The only thing problem is the --extra-headers arg's not working 😅 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant