Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Localization] [UI/UX] Updates for pokemon-emerald-pro & pkmnems #4968

Open
wants to merge 3 commits into
base: beta
Choose a base branch
from

Conversation

Adri1
Copy link
Contributor

@Adri1 Adri1 commented Dec 4, 2024

What are the changes the user will see?

Nearly none, the impacted letters are not used yet in any of the current accessible languages
The only change is a reshape of the number 0 (zero) to not be mistaken for the letter O

Zero Before:
image

Zero after:
image

Why am I making these changes?

  • Romanian is a language that wants to be introduced to Rogue
    However, the diacritics on some letters in pokemon-emerald-pro font used in romanian looked a bit of + adding some of these letters with diacritics that were non-existent in pkmnems font.
  • Reshape of the number 0 (zero) to not be mistaken for the letter O

What are the changes from a developer perspective?

None

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)

@Adri1 Adri1 requested a review from a team as a code owner December 4, 2024 01:55
@Adri1 Adri1 added Localization Provides or updates translation efforts UI/UX User interface/-experience related labels Dec 4, 2024
DayKev
DayKev previously approved these changes Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Localization Provides or updates translation efforts UI/UX User interface/-experience related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants