Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the nav menu scrollable #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ParadoxV5
Copy link

When the <nav> menu has many items (is long) or on short-height windows or screens, the <nav> simply overflows the window with the overflown items cut-off and inaccessible. This quick-fix proposal constraints the <nav> at the bottom and enables scrolling for overflow behaviour.

Although, browsers’ – at least Chrome – scrollbars look thicc and out of place.

I discovered this oversight while trying to fix #48/#62. This can be an initiating step, as the next would be making the bottom retract to make room for the <footer> (which has non-constant height, and I am not aware of how to respond to that).

for long menus and/or short-height windows/screens
@welcome
Copy link

welcome bot commented Mar 15, 2022

Welcome! Congrats on your first pull request to the Leap Day theme. If you haven't already, please be sure to check out the contributing guidelines.

@markcmiller86
Copy link

@ParadoxV5 thanks for this! It works for me and I really needed it 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Left side menu is over lapping the footer section
3 participants