Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct chained method alias #5

Merged
merged 1 commit into from
Mar 24, 2019
Merged

Conversation

petiepooo
Copy link

The way it was, you changed the base class parse_redmine_links method to parse_redmine_links_without_project_alias, then just changed it back. What you meant to do is replace the base method so it calls parse_redmine_links_with_project_alias, which is defined right below, and which calls the original (now renamed) method if needed..

I know.. it took me a while to wrap my head around that too. :)

@tofi86 tofi86 self-assigned this Mar 24, 2019
@tofi86 tofi86 added the bug label Mar 24, 2019
@tofi86
Copy link
Collaborator

tofi86 commented Mar 24, 2019

Oh, good catch!! 👏

Sorry for introducing this regression with the latest update. I followed this post https://littlelines.com/blog/2018/01/31/replace-alias-method-chain because I didn't want to refactor for Module#prepend but probably got confused between the lines by without and with...

refs 0e30777

@tofi86 tofi86 merged commit 67e04a3 into paginagmbh:master Mar 24, 2019
@petiepooo petiepooo deleted the alias branch March 26, 2019 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants