PIN-6002 - Listing templates #1463
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carminepo2
requested review from
beetlecrunch,
galales,
AsterITA and
taglioni-r
as code owners
Base automatically changed from
pin-6003_get-single-template
to
feature/pin-4901_e-service-template
February 5, 2025 14:59
MalpenZibo
reviewed
Feb 5, 2025
Comment on lines
125
to
143
| $nor: [ | ||
| { | ||
| $and: [ | ||
| { "data.creatorId": { $ne: authData.organizationId } }, | ||
| { "data.versions": { $size: 0 } }, | ||
| ], | ||
| }, | ||
| { | ||
| $and: [ | ||
| { "data.creatorId": { $ne: authData.organizationId } }, | ||
| { "data.versions": { $size: 1 } }, | ||
| { | ||
| "data.versions.state": { | ||
| $eq: eserviceTemplateVersionState.draft, | ||
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| ], |
There was a problem hiding this comment.
I find this filter quite confusing. I'm trying to understand it by reading the SRS and I suppose that this is the filter to remove draft versions if the caller is not the creator. Am I correct? In that case, Couldn't the filter be simplified?
There was a problem hiding this comment.
I semplified the whole query as such:
{
$nor: [
{
"data.creatorId": { $ne: authData.organizationId },
"data.versions": { $size: 1 },
"data.versions.state": eserviceTemplateVersionState.draft,
},
],
}
: {
$nor: [
{
"data.versions": { $size: 1 },
"data.versions.state": {
$eq: eserviceTemplateVersionState.draft,
},
},
],
};I removed the check for the empty version arra, it could never happed with our actual implementation.
LMK
There was a problem hiding this comment.
I'm still confused. Why are you using nor with only one expression inside?
There was a problem hiding this comment.
I might be wrong but I think that's the only way to have a "$not" operator at that level on documentDB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PIN-6002
Merge after #1443