Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOCOM-1595] New messages flows as default #5984

Merged
merged 11 commits into from
Jul 17, 2024

Conversation

Vangaorth
Copy link
Contributor

@Vangaorth Vangaorth commented Jul 17, 2024

Short description

This PR unlinks the old message section in favour of the new one.

List of changes proposed in this pull request

  • All navigators have been updated in order to only link the new message flows
  • Fixed bottom tab bar style so that it does not change upon tab switching
  • Blocked catching of user events when tapping a service logo in the new message home

Please note that old code is unliked but it will be removed in a future PR.

How to test

Using the io-dev-api-server, check that any kind of message is rendered with its proper new DS flow

@pagopa-github-bot pagopa-github-bot changed the title [IOCOM-1595] New messages flows as default chore: [IOCOM-1595] New messages flows as default Jul 17, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jul 17, 2024

Affected stories

  • ⚙️ IOCOM-1595: [APP] Impostare come default tutto il nuovo flusso dei messaggi con nuovo DS
    subtask of
    • IOCOM-810: Adottare il nuovo design system nella Home dei messaggi

Generated by 🚫 dangerJS against b6c798c

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.14%. Comparing base (4f204b4) to head (b6c798c).
Report is 283 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5984      +/-   ##
==========================================
+ Coverage   48.42%   49.14%   +0.71%     
==========================================
  Files        1488     1718     +230     
  Lines       31617    34420    +2803     
  Branches     7669     8336     +667     
==========================================
+ Hits        15311    16915    +1604     
- Misses      16238    17445    +1207     
+ Partials       68       60       -8     
Files Coverage Δ
...res/messages/components/Home/ArchiveRestoreBar.tsx 53.57% <100.00%> (ø)
...es/messages/components/Home/DS/MessageListItem.tsx 100.00% <ø> (ø)
...sages/components/MessageDetail/MessageMarkdown.tsx 100.00% <100.00%> (+16.66%) ⬆️
...features/messages/navigation/MessagesNavigator.tsx 33.33% <ø> (+17.94%) ⬆️
ts/features/pn/components/MessageFooter.tsx 65.21% <100.00%> (ø)
ts/hooks/useBottomTabNavigatorStyle.ts 100.00% <100.00%> (ø)
ts/screens/profile/DeveloperModeSection.tsx 25.89% <ø> (+21.42%) ⬆️
ts/store/actions/persistedPreferences.ts 100.00% <ø> (ø)
ts/store/reducers/persistedPreferences.ts 72.58% <ø> (+3.22%) ⬆️
ts/features/euCovidCert/navigation/navigator.tsx 66.66% <0.00%> (ø)
... and 3 more

... and 1035 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ae3af1...b6c798c. Read the comment docs.

@Vangaorth Vangaorth marked this pull request as ready for review July 17, 2024 12:40
@Vangaorth Vangaorth requested review from thisisjp and a team as code owners July 17, 2024 12:40
Copy link
Contributor

@forrest57 forrest57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vangaorth Vangaorth merged commit d9fc8f6 into master Jul 17, 2024
13 checks passed
@Vangaorth Vangaorth deleted the IOCOM-1595-newMessages branch July 17, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants