Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Cross): [IOAPPX-357] Upgrade @gorhom/bottom-sheet library #6062

Open
wants to merge 47 commits into
base: master
Choose a base branch
from
Open

chore(Cross): [IOAPPX-357] Upgrade @gorhom/bottom-sheet library #6062

wants to merge 47 commits into from

Conversation

CrisTofani
Copy link
Contributor

@CrisTofani CrisTofani commented Jul 29, 2024 •
edited
Loading

Short description

This PR aims to upgrade bottom-sheet library to solve rendering glitches

List of changes proposed in this pull request

  • Updates Bottom-sheets library to latest stable
  • Removes accessibility patch since it has been included in the library code

How to test

Check the bottom-sheet behaviour to be self consistent

@pagopa-github-bot pagopa-github-bot changed the title [IOAPPX-357] Upgrades bottom-sheets library chore(Cross): [IOAPPX-357] Upgrades bottom-sheets library Jul 29, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jul 29, 2024 •
edited by jira bot
Loading

Affected stories

  • ⚙️ IOAPPX-357: [io-app] Aggiornamento libreria bottom-sheet alla 4.6.x per verificare la risoluzione dei glitch attualmente presenti

Generated by 🚫 dangerJS against 31ffc89

@CrisTofani CrisTofani marked this pull request as ready for review July 29, 2024 15:29
@CrisTofani CrisTofani requested a review from a team as a code owner July 29, 2024 15:29
@dmnplb dmnplb changed the title chore(Cross): [IOAPPX-357] Upgrades bottom-sheets library chore(Cross): [IOAPPX-357] Upgrade @gorhom/bottom-sheet library Jul 30, 2024
@dmnplb
Copy link
Contributor

dmnplb commented Jul 30, 2024 •
edited
Loading

The problem we discussed yesterday does not seem to be related to the package version. By the way, I noticed that the visual issue seems to be related to the Autoresizable... ones, because the static ones work fine.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 19, 2024 •
edited by jira bot
Loading

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOAPPX-357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmnplb dmnplb Awaiting requested review from dmnplb dmnplb is a code owner

@ChrisMattew ChrisMattew Awaiting requested review from ChrisMattew ChrisMattew is a code owner

@gispada gispada Awaiting requested review from gispada gispada is a code owner

@freddi301 freddi301 Awaiting requested review from freddi301 freddi301 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Cross dependencies dont-merge ✋
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CrisTofani @pagopa-github-bot @dmnplb @LazyAfternoons @LeleDallas @Hantex9