-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Cross): [IOAPPX-395] Open autoresizable bottom sheet on first tap on iOS #6281
base: master
Are you sure you want to change the base?
Conversation
Affected stories
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6281 +/- ##
==========================================
- Coverage 48.42% 47.00% -1.43%
==========================================
Files 1488 1815 +327
Lines 31617 36902 +5285
Branches 7669 8778 +1109
==========================================
+ Hits 15311 17346 +2035
- Misses 16238 19499 +3261
+ Partials 68 57 -11
... and 1441 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we will work on a better solution in another PR with the new version of the library
Short description
This PR attempts to fix an issue with the autoresizable bottom sheet on iOS: on this platform the bottom sheet does not open on first tap.
The workaround is to increase the default snap point on iOS: with a bigger value the bottom sheet is opened immediately, but a slight flash remains.
List of changes proposed in this pull request
How to test
Use the bottom sheet screen in the Design System playground.
Please test as many instances of the autoresizable bottom sheet as possible, to ensure the workaround covers all cases.
ios_before.MP4
ios_after.MP4