Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Cross): [IOAPPX-395] Open autoresizable bottom sheet on first tap on iOS #6281

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

gispada
Copy link
Collaborator

@gispada gispada commented Oct 14, 2024

Short description

This PR attempts to fix an issue with the autoresizable bottom sheet on iOS: on this platform the bottom sheet does not open on first tap.

The workaround is to increase the default snap point on iOS: with a bigger value the bottom sheet is opened immediately, but a slight flash remains.

List of changes proposed in this pull request

  • Increased default snap point on iOS

How to test

Use the bottom sheet screen in the Design System playground.

Please test as many instances of the autoresizable bottom sheet as possible, to ensure the workaround covers all cases.

Before (iOS) After (iOS)
ios_before.MP4
ios_after.MP4

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 14, 2024

Affected stories

  • 🐞 IOAPPX-395: [io-app] Workaround iOS per autoresizable bottom sheet che non si apre al primo tap

Generated by 🚫 dangerJS against 31bb60c

@gispada gispada changed the title fix(Cross): Open autoresizable bottom sheet on first tap on iOS fix(Cross): [IOAPPX-395] Open autoresizable bottom sheet on first tap on iOS Oct 14, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.00%. Comparing base (4f204b4) to head (31bb60c).
Report is 663 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6281      +/-   ##
==========================================
- Coverage   48.42%   47.00%   -1.43%     
==========================================
  Files        1488     1815     +327     
  Lines       31617    36902    +5285     
  Branches     7669     8778    +1109     
==========================================
+ Hits        15311    17346    +2035     
- Misses      16238    19499    +3261     
+ Partials       68       57      -11     
Files with missing lines Coverage Δ
ts/utils/hooks/bottomSheet.tsx 76.27% <100.00%> (-1.92%) ⬇️

... and 1441 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c43bc0b...31bb60c. Read the comment docs.

Copy link
Contributor

@LazyAfternoons LazyAfternoons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we will work on a better solution in another PR with the new version of the library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants