feat: [IOPLT-724] Split up the backend status for better handling #6296
+1,133
−1,440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atus-split-and-reorg
pagopa-github-bot
changed the title
…us-split-and-reorg
…us-split-and-reorg
Vangaorth
requested review from
ChrisMattew,
gispada and
freddi301
as code owners
Vangaorth
requested changes
Oct 31, 2024
| return state; | ||
| }; | ||
|
|
||
| export const backendInfoSelector = (state: GlobalState) => state.backendInfo; |
There was a problem hiding this comment.
Since this selector is "a thing of the past" and it is used only in ts/sagas/backendStatus.ts, should we remove it and refactor the latter to use isBackendServicesStatusOffSelector and a new deadsCounterSelector?
| @@ -49,8 +49,9 @@ export function* backendStatusWatcherLoop( | |||
| backendStatusSaga, | |||
| getStatus | |||
| ); | |||
| const currentState: ReturnType<typeof backendServicesStatusSelector> = | |||
| yield* select(backendServicesStatusSelector); | |||
| const currentState: ReturnType<typeof backendInfoSelector> = yield* select( | |||
There was a problem hiding this comment.
See comment on the reducer's file about removing this one in favour of two distinct selectors
| @@ -241,7 +241,7 @@ export function* initializeApplicationSaga( | |||
| // Since the backend.json is done in parallel with the startup saga, | |||
| // we need to synchronize the two tasks, to be sure to have loaded the remote FF | |||
| // before using them. | |||
| const backendStatus = yield* select(backendStatusSelector); | |||
| const backendStatus = yield* select(remoteConfigSelector); | |||
There was a problem hiding this comment.
Should we rename backendStatus to remoteConfig ?
| import { getFullLocale } from "../../utils/locale"; | ||
| const SystemOffModal = () => { | ||
| const backendStatus = useSelector(backendStatusSelector, _.isEqual); | ||
| const backendInfoMessage = useSelector(backendInfoMessageSelector); |
There was a problem hiding this comment.
Removing the _.isEqual comparison function may change the desired behaviour. Are we sure about this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR aims to split the
backendStatusreducer and store section into 4 different reducersList of changes proposed in this pull request
backendStatusreducerremoteConfig,sectionStatus,backendInfo,statusMessagesreducersHow to test
Anything should work properly as usual after changes.