-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [IOCOM-1665] FIMS Authentication proper UI #6351
Open
Vangaorth
wants to merge
14
commits into
master
Choose a base branch
from
IOCOM-1665_fimsAuthErrorScreen
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+158
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vangaorth
requested review from
thisisjp,
a team,
ChrisMattew,
gispada and
freddi301
as code owners
October 31, 2024 10:10
pagopa-github-bot
changed the title
[IOCOM-1665] FIMS Authentication proper UI
feat: [IOCOM-1665] FIMS Authentication proper UI
Oct 31, 2024
Affected stories
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR implements the UI for a FIMS Authentication error.
SSO error
Generic error
SSO error
Generic error
List of changes proposed in this pull request
handleFimsGetConsentsList
refactored to distinguish between a generic error and a specific SSO oneFimsFullScreenErrors
refactored to retrieve error type and error content on its own. It also uses theuseDebugInfo
hook to display debug data when such mode is onFIMSFlowHandlerScreen
refactored to detect an error and return theFimsFullScreenErrors
component, instead of passing the specific error to the latterAUTHENTICATION
tag added toFIMS_SSO_ERROR_TAGS
DEBUG
tag removed fromFIMS_SSO_ERROR_TAGS
(it is now handled by theuseDebugInfo
hook, combined with the newfimsDebugDataSelector
)fimsAuthenticationFailedSelector
andfimsAuthenticationErrorTagSelector
to know if there was an error and to retrieve its categorystandardMessage
data and its selector/usagesconsentsData
renamed tossoData
since it is also used after consents have been retrievedHow to test
Using the io-dev-api-server, modify the Relying Party redirect to send invalid parameters (like the
clientId
,scopes
and so on). Check that the proper error screen is displayed. To test the generic error, change any other flow (starting from the consents list sending) to return a 500 http status error code.