Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOCOM-1665] FIMS Authentication proper UI #6351

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

Vangaorth
Copy link
Contributor

⚠️ This PR depends on #6330 ⚠️

Short description

This PR implements the UI for a FIMS Authentication error.

iOS
SSO error
iOS
Generic error
iOSOne iOSTwo
Android
SSO error
Android
Generic error
AndroidOne AndroidTwo

List of changes proposed in this pull request

  • handleFimsGetConsentsList refactored to distinguish between a generic error and a specific SSO one
  • FimsFullScreenErrors refactored to retrieve error type and error content on its own. It also uses the useDebugInfo hook to display debug data when such mode is on
  • FIMSFlowHandlerScreen refactored to detect an error and return the FimsFullScreenErrors component, instead of passing the specific error to the latter
  • AUTHENTICATION tag added to FIMS_SSO_ERROR_TAGS
  • DEBUG tag removed from FIMS_SSO_ERROR_TAGS (it is now handled by the useDebugInfo hook, combined with the new fimsDebugDataSelector)
  • New fimsAuthenticationFailedSelector and fimsAuthenticationErrorTagSelector to know if there was an error and to retrieve its category
  • Removed deprecated standardMessage data and its selector/usages
  • consentsData renamed to ssoData since it is also used after consents have been retrieved

How to test

Using the io-dev-api-server, modify the Relying Party redirect to send invalid parameters (like the clientId, scopes and so on). Check that the proper error screen is displayed. To test the generic error, change any other flow (starting from the consents list sending) to return a 500 http status error code.

@pagopa-github-bot pagopa-github-bot changed the title [IOCOM-1665] FIMS Authentication proper UI feat: [IOCOM-1665] FIMS Authentication proper UI Oct 31, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 31, 2024

Affected stories

  • 🌟 IOCOM-1665: [App] Adeguare la schermata di errore (UI/UX) nel flusso di autenticazione secondo il FIGMA
    subtask of
    • IOCOM-1659: [FIMS, App] Attività implementative pre-rilascio

Generated by 🚫 dangerJS against 666f7e0

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 12.00000% with 44 lines in your changes missing coverage. Please review.

Project coverage is 47.07%. Comparing base (4f204b4) to head (666f7e0).
Report is 656 commits behind head on master.

Files with missing lines Patch % Lines
...ims/singleSignOn/saga/handleFimsGetConsentsList.ts 11.11% 16 Missing ⚠️
...eatures/fims/singleSignOn/store/selectors/index.ts 21.42% 11 Missing ⚠️
...s/singleSignOn/components/FimsFullScreenErrors.tsx 11.11% 8 Missing ⚠️
...ims/singleSignOn/screens/FimsFlowHandlerScreen.tsx 0.00% 4 Missing ⚠️
ts/features/fims/singleSignOn/saga/sagaUtils.ts 0.00% 2 Missing ⚠️
ts/features/fims/singleSignOn/utils/index.ts 0.00% 2 Missing ⚠️
...s/fims/singleSignOn/components/FimsSuccessBody.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6351      +/-   ##
==========================================
- Coverage   48.42%   47.07%   -1.36%     
==========================================
  Files        1488     1809     +321     
  Lines       31617    36819    +5202     
  Branches     7669     8853    +1184     
==========================================
+ Hits        15311    17332    +2021     
- Misses      16238    19421    +3183     
+ Partials       68       66       -2     
Files with missing lines Coverage Δ
ts/features/fims/history/api/client.ts 50.00% <ø> (ø)
...es/fims/history/components/FimsHistoryListItem.tsx 33.33% <ø> (ø)
.../history/components/FimsHistoryNonEmptyContent.tsx 5.88% <ø> (ø)
ts/features/fims/history/store/actions/index.ts 100.00% <ø> (ø)
ts/features/fims/history/store/reducer/index.ts 24.00% <ø> (ø)
...atures/fims/singleSignOn/components/FimsClaims.tsx 37.50% <ø> (ø)
...eSignOn/saga/handleFimsGetRedirectUrlAndOpenIAB.ts 3.59% <ø> (ø)
.../features/fims/singleSignOn/store/actions/index.ts 100.00% <ø> (ø)
...features/fims/singleSignOn/store/reducers/index.ts 24.00% <ø> (ø)
...s/fims/singleSignOn/components/FimsSuccessBody.tsx 9.09% <0.00%> (ø)
... and 6 more

... and 1416 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b439e0...666f7e0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants