Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-837] Add payee name as header title into transaction details #6354

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented Oct 31, 2024

Short description

This PR adds the payee entity's name to the header with a discrete transition effect.

List of changes proposed in this pull request

  • Replaced the IOScrollViewWithLargeHeader with the IOScrollView that uses the animatedRef to the custom hook useHeaderSecondLevel to show the discrete transition in the header while scrolling

How to test

  • Open the Payments screen tab;
  • Choose any transaction from the list navigating to the transaction details screen;
  • While scrolling, you should be able to see the discrete transition of the header with the payee entity's name;

Preview

preview.mov

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 31, 2024

Affected stories

  • ⚙️ IOBP-837: [Schermata dettaglio ricevuta] Rimuovere titolo "statico" ed inserire nome dell'Ente
    subtask of
    • IOBP-246: Evolutive sezione Pagamenti

Generated by 🚫 dangerJS against 74ba39d

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 47.04%. Comparing base (4f204b4) to head (74ba39d).
Report is 659 commits behind head on master.

Files with missing lines Patch % Lines
...eens/PaymentsTransactionBizEventsDetailsScreen.tsx 0.00% 4 Missing ⚠️
...nts/PaymentsBizEventsTransactionHeadingSection.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6354      +/-   ##
==========================================
- Coverage   48.42%   47.04%   -1.38%     
==========================================
  Files        1488     1811     +323     
  Lines       31617    36863    +5246     
  Branches     7669     8872    +1203     
==========================================
+ Hits        15311    17344    +2033     
- Misses      16238    19453    +3215     
+ Partials       68       66       -2     
Files with missing lines Coverage Δ
...nts/PaymentsBizEventsTransactionHeadingSection.tsx 3.84% <0.00%> (ø)
...eens/PaymentsTransactionBizEventsDetailsScreen.tsx 8.10% <0.00%> (ø)

... and 1433 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b12d7b6...74ba39d. Read the comment docs.

@Hantex9 Hantex9 merged commit c57f072 into master Oct 31, 2024
13 checks passed
@Hantex9 Hantex9 deleted the IOBP-837-dynamic-transaction-header-title branch October 31, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants