Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#PE-878] Fixed card messages #35

Merged
merged 2 commits into from
Dec 23, 2024
Merged

[#PE-878] Fixed card messages #35

merged 2 commits into from
Dec 23, 2024

Conversation

michaeldisaro
Copy link
Contributor

List of Changes

Fixed card messages to be correctly formatted by message builder, using \n instead of blank lines.

Motivation and Context

There is a bug that break message building because of blank lines.

How Has This Been Tested?

  • test message sending

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@michaeldisaro michaeldisaro requested a review from a team as a code owner December 23, 2024 14:31
@michaeldisaro michaeldisaro merged commit caa14c7 into main Dec 23, 2024
8 of 9 checks passed
@michaeldisaro michaeldisaro deleted the pe-828 branch December 23, 2024 15:01
@michaeldisaro michaeldisaro changed the title [#PE-828] Fixed card messages [#PE-878] Fixed card messages Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michaeldisaro