[#176013578] added code-review and deploy pipeline #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
balanza
reviewed
Jan 18, 2021
.devops/deploy-pipelines.yml
Outdated
Comment on lines
94
to
96
| - script: | | ||
| yarn pack | ||
| displayName: 'Pack' |
There was a problem hiding this comment.
why do we need this script?
There was a problem hiding this comment.
I thought it was necessary to create the package
There was a problem hiding this comment.
i's actually done internally by the yarn publish command, which is itself executed by the Npm azure task
There was a problem hiding this comment.
There was a problem hiding this comment.
ok, sorry I didn't know.. so I suppose I need to add .ios and android folders to the file list, to let them be packed, right?
There was a problem hiding this comment.
Good point. How was this package published so far? We should mimic such process cc @Undermaken
balanza
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] create pipeline code-review
[x] create deploy pipeline